Fix ci e2e-tests build and update node to v18 #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
affects: @joystream/bn-typeorm, @joystream/hydra-cli, @joystream/hydra-common, @joystream/hydra-db-utils, @joystream/hydra-e2e-tests, @joystream/hydra-indexer-gateway, @joystream/hydra-indexer, @joystream/hydra-processor, @joystream/hydra-typegen, sample, sample-mappings nodejs 14 is no longer supported. v18 is now recommended for security and performance reasons
pulling from docker hub now requires login
…am/node instead affects: @joystream/hydra-e2e-tests
mnaamani
changed the title
affects: @joystream/hydra-e2e-tests, @joystream/hydra-indexer, @joystream/hydra-processor
affects: @joystream/hydra-e2e-tests
…ting affects: @joystream/hydra-e2e-tests
…2001 affects: @joystream/hydra-e2e-tests, @joystream/hydra-indexer, @joystream/hydra-processor
Updating to node:18 docker images broke the native build of bufferutil package which does not provide pre-built native modules for arm64 arch. The bundled version of node-gyp fails to build the package with python3.11 so had to update node-gyp to latest version with the fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly addressing #529
joystream/nodedocker image in e2e tests, the paritytech images are failing to download even after authenticating to docker..